Skip to content

Update build.sh and release.sh to include amd64 freebsd

wikrie requested to merge (removed):master into master

MERGE REQUEST

Overview

Following patches for this PR is to build amd64 freebsd binaries for spd and spc. I have used 2 patches below to build the spd and spc binaries for freebsd. I currently use this freebsd v1.6.2 release build in my TrueNAS-12.0-U8 server in a jail successfully and I am online as a working freebsd storage provider.

Would be nice to have these 2 patches accepted. Even greater if this freebsd release would be made publicly available as freebsd software download link on https://scpri.me/software/

Example for Visual changes (ie Screenshot)

diff --git a/build.sh b/build.sh index b658d02b8..761d2040c 100755 --- a/build.sh +++ b/build.sh @@ -13,6 +13,7 @@ for arch in amd64 arm; do for pkg in spc spd; do # Ignore unsupported arch/os combinations. if [ "$arch" == "arm" ]; then

  •                           # Add FreeBSD as OS Type 
                          if [ "$os" == "windows" ] || [ "$os" == "darwin" ] || [ "$os" == "freebsd" ]; then
                                  continue
                          fi

diff --git a/release.sh b/release.sh index 4bf0b4d82..61ca1e13a 100755 --- a/release.sh +++ b/release.sh @@ -31,6 +31,7 @@ for arch in amd64 arm; do for os in darwin linux windows freebsd; do

            # We don't need ARM versions for windows or mac (just linux)
  •           # Add FreeBSD as OS Type
          if [ "$arch" == "arm" ]; then
                  if [ "$os" == "windows" ] || [ "$os" == "darwin" ] || [ "$os" == "freebsd" ]; then
                          continue

(END)...skipping... diff --git a/build.sh b/build.sh index b658d02b8..761d2040c 100755 --- a/build.sh +++ b/build.sh @@ -13,6 +13,7 @@ for arch in amd64 arm; do for pkg in spc spd; do # Ignore unsupported arch/os combinations. if [ "$arch" == "arm" ]; then

  •                           # Add FreeBSD as OS Type 
                          if [ "$os" == "windows" ] || [ "$os" == "darwin" ] || [ "$os" == "freebsd" ]; then
                                  continue
                          fi

diff --git a/release.sh b/release.sh index 4bf0b4d82..61ca1e13a 100755 --- a/release.sh +++ b/release.sh @@ -31,6 +31,7 @@ for arch in amd64 arm; do for os in darwin linux windows freebsd; do

            # We don't need ARM versions for windows or mac (just linux)
  •           # Add FreeBSD as OS Type
          if [ "$arch" == "arm" ]; then
                  if [ "$os" == "windows" ] || [ "$os" == "darwin" ] || [ "$os" == "freebsd" ]; then
                          continue

Issues Closed

Checklist

Review and complete the checklist to ensure that the MR is complete before assigned to an approver.

  • All new methods, or updating methods have clear docstrings
  • Testing added or updated for new methods
  • Any new packages are added to Makefile and .gitlab-ci.yml
  • API documentation updated for API updates
  • Module README.md updated for changes to work flow
  • Issue added to ScPrime-UI repo for new supporting features

Merge request reports