Replace node sass with sass
Closes the node-sass
part of #1047
What does this MR do?
LibSass and NodeSass are deprecated, DartSass is the (new) primary implementation of Sass. Moving is recommended and should be as easy as replacing node-sass
with sass
in the package.json:
If you’re a user of Node Sass, migrating to Dart Sass is straightforward: just replace node-sass in your package.json file with sass. Both packages expose the same JavaScript API.
Updating lead to a single compile bug that was fixed here.
How confident are you it won't break things if deployed?
85 %
Links to related issues
Will close the node-sass
part of foodsharing-dev/foodsharing#1047
How to test
Fire up the app and see it not crash
Screenshots (if applicable)
No visible changes
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Edited by Jannes