Fix some plugin 'amp' arguments
@zkonate1 asked for this to be fixed. Attention @djiamnot!
Some SATIE plugins use the amp
argument to set Env.adsr
's peakLevel
value. This is incorrect since peakLevel
isn't a parameter than can be changed over time. It is used initialy when creating the envelope and that's it. I believe that many plugins were sounding quieter than intended before this fix.
What has changed?
- if there was an
Env.adsr
withamp
aspeakLevel
, it was removed.peakLevel
has a default value of 1.0 which is ideal. -
amp
is now used as a multiplier like so:sig * envGen * amp
- some
amp
argument default values were increased to 1, although most were kept at 0.75 - some clipping of the
amp
argument have been removed
You should be noticing sources have gotten louder as a result of this MR.