s4:torture: Correctly cleanup in smb2.streams torture tests (revealed two bugs)

Andreas Schneiderrequested to merge
samba-team/devel/samba:asn-torture into master

We often do not cleanup in torture tests. Sanitizers complain about this so I started to work on on that. It revealed bugs in the server code. We really to write proper code with cleanup in torture tests!

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports