Fix bug samba-tool group addmembers with 16 character names (bug 15854)

Douglas Bagnallrequested to merge
samba-team/devel/samba:douglas-bug-15854-group-addmembers into master

https://bugzilla.samba.org/show_bug.cgi?id=15854

# samba-tool group addmembers abcdefghijklmnop user
ERROR: Failed to add members ['user'] to group "abcdefghijklmnop" - (32, "Base-DN '<GUID=64636261-6665-6867-696a-6b6c6d6e6f70>' not found")

This is a regression caused by commit 21a88df0. add_remove_group_members() now tries to interpret the group name as GUID first, which eventually succeeds in GUID_from_data_blob() and GUID_from_ndr_blob() for arbitrary strings with 16 characters.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports