Skip to content

Some code fixes

Andreas Schneider requested to merge samba-team/devel/samba:asn/master-fix into master

I've added a csbuild on a private runner.

csbuild is a static analysis tool by RH it runs clang, cppcheck etc. I'm using it in several projects successfully to ensure better code quality (libssh, cmocka, cwrap).

It would be great to also turn it on for Samba but it shows there is a lot of work ahead. The csbuild branch is here:

https://gitlab.com/samba-team/devel/samba/commits/asn/master-csbuild

The results are here:

https://gitlab.com/samba-team/devel/samba/-/jobs/204481431

It would be great if someone could look into the python pidl stuff. The problem is the casting of function pointers. The ml_meth of PyMethodDef should be a union to assign different function types.

I've found https://bugs.python.org/issue33012

They cast it to (void *) which hides it from the compiler because the API is bad :-(

See https://github.com/python/cpython/commit/359a2f3daba49fde0d3a07fb3c7a8b051c450d08

Merge request reports