add server support for netr_ServerAuthenticateKerberos

Checklist

• Commits have Signed-off-by: with name/author being identical to the commit author
• (optional) This MR is just one part towards a larger feature.
• (optional, if backport required) Bugzilla bug filed and BUG: tag added
• Test suite updated with functionality tests
• Test suite updated with negative tests
• Documentation updated
• CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

• There is a test suite reasonably covering new functionality or modifications
• Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
• This feature/change has adequate documentation added
• No obvious mistakes in the code

added 2 commits

• 1670465e - source4/rpc_server/netlogon/dcerpc_netlogon.c...
• bdd67510 - python/samba/tests/krb5/netlogon.py re-add some krb5 broken_crypto TODO check_passwords

Compare with previous version

added 54 commits

• bdd67510...4211e1ef - 44 earlier commits
• 62a64a8a - auth_log: prepare for netr_ServerAuthenticateKerberos
• 0ced5afa - docs-xml/smbdotconf: add "server reject aes schannel[:COMPUTERACCOUNT]" options
• 46780334 - docs-xml/smbdotconf: add "server support krb5 netlogon" options
• 82bc40af - librpc/server: prepare schannel_util.c for netr_ServerAuthenticateKerberos
• 7021dab8 - s4:rpc_server/netlogon: implement dcesrv_netr_ServerAuthenticateKerberos
• 6765892c - selftest: add 'server support krb5 netlogon = yes' for ad_dc
• aace6a93 - libcli/auth: let schannel_check_creds_state() take an access_check callback
• bb099fea - librpc/server: call dcesrv_netr_check_schannel() as schannel_check_creds_state() callback
• 3157983f - s4:rpc_server/netlogon: fix dcesrv_netr_ServerPasswordSet[2] for ServerAuthenticateKerberos
• 52af1063 - s4:rpc_server/netlogon: fix dcesrv_netr_LogonSamLogon_base_call() for ServerAuthenticateKerberos()

Compare with previous version

changed title from Draft: add support for netr_ServerAuthenticateKerberos to Draft: add server support for netr_ServerAuthenticateKerberos

added 14 commits

• 52af1063...21a9b499 - 4 earlier commits
• 42c17c94 - auth_log: prepare for netr_ServerAuthenticateKerberos
• a7ab9ed0 - docs-xml/smbdotconf: add "server reject aes schannel[:COMPUTERACCOUNT]" options
• 200c8ec3 - docs-xml/smbdotconf: add "server support krb5 netlogon" options
• 32e9291f - librpc/server: prepare schannel_util.c for netr_ServerAuthenticateKerberos
• 2cd2f37e - s4:rpc_server/netlogon: implement dcesrv_netr_ServerAuthenticateKerberos
• ca0e2d77 - selftest: add 'server support krb5 netlogon = yes' for ad_dc
• b4ebf84a - libcli/auth: let schannel_check_creds_state() take an access_check callback
• fc00ec9d - librpc/server: call dcesrv_netr_check_schannel() as schannel_check_creds_state() callback
• 7ed987d0 - s4:rpc_server/netlogon: fix dcesrv_netr_ServerPasswordSet[2] for ServerAuthenticateKerberos
• 6c994835 - s4:rpc_server/netlogon: fix dcesrv_netr_LogonSamLogon_base_call() for ServerAuthenticateKerberos()

Compare with previous version

added 2 commits

• 07dbe2ae - s4:rpc_server/netlogon: fix dcesrv_netr_ServerPasswordSet[2] for ServerAuthenticateKerberos
• 68afae71 - s4:rpc_server/netlogon: fix dcesrv_netr_LogonSamLogon_base_call() for ServerAuthenticateKerberos()

Compare with previous version

added 16 commits

• 68afae71...ecb0f0dc - 6 earlier commits
• ab3a274b - docs-xml/smbdotconf: add "server reject aes schannel[:COMPUTERACCOUNT]" options
• c0c759af - docs-xml/smbdotconf: add "server support krb5 netlogon" options
• 9632ce22 - librpc/server: prepare schannel_util.c for netr_ServerAuthenticateKerberos
• 80c39fba - s4:rpc_server/netlogon: implement dcesrv_netr_ServerAuthenticateKerberos
• 6e1d60a5 - selftest add 'server reject aes schannel:COMPUTER$' rules
• 6b21db0a - selftest: add 'server support krb5 netlogon = yes' for ad_dc
• c8f65d2c - libcli/auth: let schannel_check_creds_state() take an access_check callback
• a55411a2 - librpc/server: call dcesrv_netr_check_schannel() as schannel_check_creds_state() callback
• e145c87f - s4:rpc_server/netlogon: fix dcesrv_netr_ServerPasswordSet[2] for ServerAuthenticateKerberos
• 54230c9c - s4:rpc_server/netlogon: fix dcesrv_netr_LogonSamLogon_base_call() for ServerAuthenticateKerberos()

Compare with previous version

marked this merge request as ready

requested review from @jsutton24

requested review from @douglasbagnall

added 118 commits

• 54230c9c...531a33b9 - 102 commits from branch samba-team:master
• 531a33b9...0d60e110 - 6 earlier commits
• f9354a9a - docs-xml/smbdotconf: add "server reject aes schannel[:COMPUTERACCOUNT]" options
• 76511995 - docs-xml/smbdotconf: add "server support krb5 netlogon" options
• 6df4a0a8 - librpc/server: prepare schannel_util.c for netr_ServerAuthenticateKerberos
• 7bccdd46 - s4:rpc_server/netlogon: implement dcesrv_netr_ServerAuthenticateKerberos
• f3d8f4a0 - selftest add 'server reject aes schannel:COMPUTER$' rules
• 2dfe9849 - selftest: add 'server support krb5 netlogon = yes' for ad_dc
• 2d61c725 - libcli/auth: let schannel_check_creds_state() take an access_check callback
• 45393e50 - librpc/server: call dcesrv_netr_check_schannel() as schannel_check_creds_state() callback
• dec6cf86 - s4:rpc_server/netlogon: fix dcesrv_netr_ServerPasswordSet[2] for ServerAuthenticateKerberos
• 9c992704 - s4:rpc_server/netlogon: fix dcesrv_netr_LogonSamLogon_base_call() for ServerAuthenticateKerberos()

Compare with previous version

added 19 commits

• 9c992704...b9755f88 - 3 commits from branch samba-team:master
• b9755f88...49ce48e7 - 6 earlier commits
• 17222cfa - docs-xml/smbdotconf: add "server reject aes schannel[:COMPUTERACCOUNT]" options
• 64626191 - docs-xml/smbdotconf: add "server support krb5 netlogon" options
• 7117e65d - librpc/server: prepare schannel_util.c for netr_ServerAuthenticateKerberos
• 4df2afaa - s4:rpc_server/netlogon: implement dcesrv_netr_ServerAuthenticateKerberos
• 662726df - selftest add 'server reject aes schannel:COMPUTER$' rules
• 4cad4607 - selftest: add 'server support krb5 netlogon = yes' for ad_dc
• cb0abda3 - libcli/auth: let schannel_check_creds_state() take an access_check callback
• af335f79 - librpc/server: call dcesrv_netr_check_schannel() as schannel_check_creds_state() callback
• 4f3a818e - s4:rpc_server/netlogon: fix dcesrv_netr_ServerPasswordSet[2] for ServerAuthenticateKerberos
• 099e8ac9 - s4:rpc_server/netlogon: fix dcesrv_netr_LogonSamLogon_base_call() for ServerAuthenticateKerberos()

Compare with previous version

added 17 commits

• 099e8ac9...079aeaca - 7 earlier commits
• abfefff3 - docs-xml/smbdotconf: add "server reject aes schannel[:COMPUTERACCOUNT]" options
• 69bc9e73 - docs-xml/smbdotconf: add "server support krb5 netlogon" options
• e3bc1a37 - librpc/server: prepare schannel_util.c for netr_ServerAuthenticateKerberos
• 1241a99f - s4:rpc_server/netlogon: implement dcesrv_netr_ServerAuthenticateKerberos
• c0552988 - selftest add 'server reject aes schannel:COMPUTER$' rules
• f5fdb85e - selftest: add 'server support krb5 netlogon = yes' for ad_dc
• e43ee2d9 - libcli/auth: let schannel_check_creds_state() take an access_check callback
• b7933e50 - librpc/server: call dcesrv_netr_check_schannel() as schannel_check_creds_state() callback
• fab5ebda - s4:rpc_server/netlogon: fix dcesrv_netr_ServerPasswordSet[2] for ServerAuthenticateKerberos
• 22179234 - s4:rpc_server/netlogon: fix dcesrv_netr_LogonSamLogon_base_call() for ServerAuthenticateKerberos()

Compare with previous version

resolved all threads

added 10 commits

• 7c41db35 - docs-xml/smbdotconf: add "server reject aes schannel[:COMPUTERACCOUNT]" options
• 6cbd4dd4 - docs-xml/smbdotconf: add "server support krb5 netlogon" options
• bdab6ced - librpc/server: prepare schannel_util.c for netr_ServerAuthenticateKerberos
• 8e3e21f0 - s4:rpc_server/netlogon: implement dcesrv_netr_ServerAuthenticateKerberos
• 220d844e - selftest add 'server reject aes schannel:COMPUTER$' rules
• 00aa393f - selftest: add 'server support krb5 netlogon = yes' for ad_dc
• 25c46f6f - libcli/auth: let schannel_check_creds_state() take an access_check callback
• 5b42e058 - librpc/server: call dcesrv_netr_check_schannel() as schannel_check_creds_state() callback
• dbeb3987 - s4:rpc_server/netlogon: fix dcesrv_netr_ServerPasswordSet[2] for ServerAuthenticateKerberos
• 07e7b537 - s4:rpc_server/netlogon: fix dcesrv_netr_LogonSamLogon_base_call() for ServerAuthenticateKerberos()

Compare with previous version

review+

cb279144

closed