s3: SIGHUP handlers use consistent log level 3

Jones Syuerequested to merge
samba-team/devel/samba:jones2019_fix_sighup_log_level into master

When turn-on 'log level = 3', sending SIGHUP to samba processes, for example: smbd parent/children, smbd-notifyd, and smbd-cleanupd. Then monitor log.smbd in order to parse sighup logs, it looks like the log level is inconsistent among these processes: smbd parent/children use level 1, and smbd-notifyd/smbd-cleanupd use level 3.

This patch raises sighup handler's log level from level 1 to level 3, which is more consistent with smbd-notifyd by Commit 6e5bff80 ("s3:notifyd: Handle sigup in notifyd to reparse smb.conf"), and smbd-cleanupd by Commit 57c1e115 ("smbd: reopen logs on SIGHUP for notifyd and cleanupd").

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15706

Before patch:

[2024/09/02 16:43:21.002435,  1] ../../source3/smbd/server.c:1420(smbd_parent_sig_hup_handler)
  parent: Reloading services after SIGHUP
[2024/09/02 16:43:21.003141,  3] ../../source3/smbd/server.c:382(notifyd_sig_hup_handler)
  notifyd_sig_hup_handler: notifyd: Reloading services after SIGHUP
[2024/09/02 16:43:21.003852,  3] ../../source3/smbd/server.c:561(cleanupd_sig_hup_handler)
  cleanupd_sig_hup_handler: cleanupd: Reloading services after SIGHUP
[2024/09/02 16:43:21.003968,  1] ../../source3/smbd/smb2_process.c:1633(smbd_sig_hup_handler)
  Reloading services after SIGHUP

After patch:

[2024/09/02 16:54:14.987507,  3] ../../source3/smbd/server.c:1420(smbd_parent_sig_hup_handler)
  smbd_parent_sig_hup_handler: parent: Reloading services after SIGHUP
[2024/09/02 16:54:14.988214,  3] ../../source3/smbd/server.c:382(notifyd_sig_hup_handler)
  notifyd_sig_hup_handler: notifyd: Reloading services after SIGHUP
[2024/09/02 16:54:14.988841,  3] ../../source3/smbd/server.c:561(cleanupd_sig_hup_handler)
  cleanupd_sig_hup_handler: cleanupd: Reloading services after SIGHUP
[2024/09/02 16:54:14.988925,  3] ../../source3/smbd/smb2_process.c:1633(smbd_sig_hup_handler)
  smbd_sig_hup_handler: Reloading services after SIGHUP

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports