Fix the Samba ABI (broken in 4.21.0rc1 and 4.20.3)
Fix the Samba ABI (broken in 4.21.0rc1 and 4.20.3)
With the fix the API seems to be correct again:
000000000001cc3b g DF .text 000000000000017b NDR_KRB5PAC_0.0.1 ndr_print_PAC_LOGON_NAME
0000000000036d1e g DF .text 0000000000000034 NDR_KRB5PAC_0.0.1 ndr_print_CLAIMS_SOURCE_TYPE
00000000000161ae g DF .text 0000000000000157 NDR_KRB5PAC_0.0.1 ndr_push_PAC_CREDENTIAL_INFO
Checklist
-
Commits have Signed-off-by:with name/author being identical to the commit author -
(optional) This MR is just one part towards a larger feature. -
(optional, if backport required) Bugzilla bug filed and BUG:tag added -
Test suite updated with functionality tests -
Test suite updated with negative tests -
Documentation updated -
CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)
Reviewer's checklist:
-
There is a test suite reasonably covering new functionality or modifications -
Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md -
This feature/change has adequate documentation added -
No obvious mistakes in the code