Skip to content

ldb: avoid O(n²) allocations in large transactions

Douglas Bagnall requested to merge samba-team/devel/samba:douglas-ldb-index into master

In long transactions involving many sub-transactions (for example, when adding data via ldif) we have been doing lots of talloc_memdup() of values that don't change. If we don't make copies and borrow the old values it can be a lot quicker.

https://bugzilla.samba.org/show_bug.cgi?id=15590

Add a description of the new feature/bug fix. Reference any relevant bugs.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports