CTDB: Use nfs-utils' sm-notify, remove CTDB's smnotify
From the 2nd commit message...
CTDB's smnotify does not support IPv6 and is difficult to maintain.
So, create directories of files and pass them to NFS util's sm-notify.
There is an implied change here, because NFS utils sm-notify stopped sending IP addresses as mon_name back in 2010:
This will change advice given in the wiki to use a hostname for the cluster with round-robin DNS, since this is what is best supported.
Another behavioural change is that sm-notify only sends "up" notifications with an odd state.
This has all been integration tested during product testing.
After this, there are still further improvements to NFSv3 lock reclaim to come.
Checklist
-
Commits have Signed-off-by:with name/author being identical to the commit author -
(optional) This MR is just one part towards a larger feature. -
(optional, if backport required) Bugzilla bug filed and BUG:tag added -
Test suite updated with functionality tests -
Test suite updated with negative tests -
Documentation updated -
CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)
Reviewer's checklist:
-
There is a test suite reasonably covering new functionality or modifications -
Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md -
This feature/change has adequate documentation added -
No obvious mistakes in the code
Edited by Amitay Isaacs