s4/torture: Fix ACCESS_DENIED errors from smb2.delete-on-close-perms

Anoop C Srequested to merge
samba-team/devel/samba:anoopcs-s4-torture-delete-on-close-fix into master

Following failures are seen in shares where ignore system acls is set for vfs_acl_xattr:

test: samba3.smb2.delete-on-close-perms.FIND_and_set_DOC
time: 2024-05-28 04:24:46.929589Z
Opening Directory for setting new SD: test_dir
get the original sd
Setting permissions on dir to 0x1f01ff
Creating Directory for testing: test_dir
get the original sd
Setting permissions on dir to 0x1e01bf
FIND and delete directory
We expect NT_STATUS_OK
time: 2024-05-28 04:24:46.947659Z
failure: samba3.smb2.delete-on-close-perms.FIND_and_set_DOC [
Exception: (../../source4/torture/smb2/delete-on-close.c:555) Incorrect status NT_STATUS_ACCESS_DENIED - should be NT_STATUS_OK

]
test: samba3.smb2.delete-on-close-perms.READONLY
time: 2024-05-28 04:24:46.947669Z
time: 2024-05-28 04:24:46.963488Z
failure: samba3.smb2.delete-on-close-perms.READONLY [
Exception: ../../source4/torture/smb2/delete-on-close.c:603: status was NT_STATUS_ACCESS_DENIED, expected NT_STATUS_OK: CREATE directory failed

]

For smb2.delete-on-close-perms.READONLY we had left overs from execution of previous subtests which couldn't be removed due to missing delete permission for the owner. In former case of smb2.delete-on-close-perms.FIND_and_set_DOC an attempt to open test_dir with certain permissions failed as few among them were lacking in first place when it got created.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Anoop C S

Merge request reports