Skip to content

Cleanups by Jo from GMSA branch

Andrew Bartlett requested to merge samba-team/devel/samba:abartlet/jo-cleanups into master

Some cleanups from !3522 (closed) split out to try and get an earlier merge of these unrelated changes an so reduce the size of the patch series.

Marked draft as "tests/krb5: type hinting" needs a signed-off-by, and because they are taken from a draft MR.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports