Skip to content

source4/torture: Add SEC_STD_DELETE to enable proper cleanup

Anoop C S requested to merge samba-team/devel/samba:anoopcs-s4-torture-add-sec-std-delete into master

With ignore system acls set alongside vfs_acl_xattr, following failure is noticed:

smbtorture 4.21.0pre1-UNKNOWN
Using seed 1707477138
time: 2024-02-09 11:12:18.649044Z
progress: 2
test: samba3.smb2.maximum_allowed.maximum_allowed
time: 2024-02-09 11:12:18.649763Z
Checked SEC_PRIV_RESTORE for S-1-5-21-1343336543-625089901-2941723812-1000 - No
Checked SEC_PRIV_BACKUP for S-1-5-21-1343336543-625089901-2941723812-1000 - No
Checked SEC_PRIV_SECURITY for S-1-5-21-1343336543-625089901-2941723812-1000 - No
time: 2024-02-09 11:12:18.676989Z
xfail: samba3.smb2.maximum_allowed.maximum_allowed [
Exception: ../../source4/torture/smb2/max_allowed.c:161: status was NT_STATUS_ACCESS_DENIED, expected NT_STATUS_OK: Incorrect status NT_STATUS_ACCESS_DENIED - should be NT_STATUS_OK

]
test: samba3.smb2.maximum_allowed.read_only
time: 2024-02-09 11:12:18.677000Z
time: 2024-02-09 11:12:18.693316Z
failure: samba3.smb2.maximum_allowed.read_only [
Exception: ../../source4/torture/smb2/max_allowed.c:212: status was NT_STATUS_OBJECT_NAME_COLLISION, expected NT_STATUS_OK: smb2_create failed

]

Even though smb2.maximum_allowed.maximum_allowed is a knownfail the subsequent sub test(smb2.maximum_allowed.read_only) fails as the very same file previously created couldn't be deleted. Restrictive SD present during creation of the file prevents it from being deleted.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports