Skip to content

gp: cert autoenroll extension assumes the current domain is the forest root

Joseph D requested to merge Outurnate/samba:mr-1 into master

Merge request implements a client for MS-ICPR, which can be used to submit certificate requests over RPC. I've also included a small python sample program to test the interface. The python API will be consumed by future additions in CEPCES. This request can stand on its own, though

I also addressed a bug where the incorrect configuration DN is generated. The configuration DN is part of the forest root domain, not the current domain. This may return referrals - future merge requests will address this.

I could not find a test suite to update for these changes. Happy to add tests if I'm pointed in the right direction

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports