Skip to content

Support non-system pkg-config for icu-i18n

Earl Chew requested to merge earlchew/samba:pkg-config-icu-i18n-01 into master

Samba configuration uses pkg-config to locate libicu, and then probes for its constituent libraries (icui18n, icuuc, icudata). This succeeds if libicu is installed as a system library, otherwise CHECK_LIB fails because the -I and -L options provided by pkg-config are not used.

This change propagates the INCLUDES_ICU_I18N and LIBPATH_ICU_I18N options that allow CHECK_LIB to succeed.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports