Skip to content

third_party/heimdal: Try to decode e-data as KERB-ERROR-DATA

Jo Sutton requested to merge samba-team/devel/samba:jsutton24/heimdal-kerb-error-data into master

Previously we tried to decode KERB-ERROR-DATA as METHOD-DATA, resulting in a confusing error message. Now we just ignore it; but we could also choose to set an error message containing the NTSTATUS code in hexadecimal.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15514

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Jo Sutton

Merge request reports