Silo command improvements and additional tests

Adds support for --user-allowed-to-authenticate-from-silo and --service-allowed-to-authenticate-from-silo to avoid the need write custom SDDL and have samba-tool generate it instead, by just passing a silo name.

Adds some previous missing test coverage + tests for the new functionality.

It doesn't make sense to have both --user-allowed-to-authenticate-from and --user-allowed-to-authenticate-from-silo present, so count the number of similar args and make sure that is only one. There is a test for this.

Some arguments were not consistent with Windows tools so have been renamed, for silos:

  • --user-policy -> --user-authentication-policy
  • --service-policy -> --service-authentication-policy
  • --computer-policy -> --computer-authentication-policy

and for policies:

  • --user-tgt-lifetime -> --user-tgt-lifetime-mins
  • --service-tgt-lifetime -> --service-tgt-lifetime-mins
  • --computer-tgt-lifetime -> --computer-tgt-lifetime-mins

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Rob van der Linde

Merge request reports

Loading
Loading