Skip to content

samba-tool: Fix crash in ‘samba tool domain level raise’

Jo Sutton requested to merge samba-team/devel/samba:jsutton24/samba-tool-domain-raise-no-url-fix into master

I guess we don’t care about whether the URL starts with “ldap” if it came from an smb.conf file?

No CI run, but I checked samba4.blackbox.functionalprep locally.

https://bugzilla.samba.org/show_bug.cgi?id=15458

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports