Skip to content

tighten up utf-8 parsing and other small changes

Douglas Bagnall requested to merge samba-team/devel/samba:douglas-enforces-utf-8 into master

Searching for "cve invalid utf-8 sequences" on a popular search engine gives "about 190,000 results" (though to be fair, MITRE only lists 139). Samba's iconv has been improving over the years, and with this we might finally get there.

My immediate concern with this is to allow round-trip assertions in fuzzers that take utf-8 strings.

Then there are other patches that just collected up. One of them might accidentally fix some printing bugs.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports