Skip to content

gpupdate: Deprecate libgpo get_gpo_list (ADS code)

David Mulder requested to merge samba-team/devel/samba:dmulder/ads_rewrite into master

The libgpo get_gpo_list function is very buggy, and relies on the old ADS code. This MR removes the last bits that depend on libgpo get_gpo_list (rewriting them in python), and adds a warning not to use it. There are still external libraries (altlinux uses this function, for example) that use get_gpo_list(), so it cannot be removed yet.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by David Mulder

Merge request reports