Skip to content

Make tests more robus against failures

Andreas Schneider requested to merge samba-team/devel/samba:asn-tests into master

We have several problems in our test. If we reuse usernames we create and sometimes cleanup doesn't happen because of a failure, then subsequent test will fail too. The user already exist and they can't create it.

This make sure we use random usernames or delete the username before we create it.

This fixes running test in mockbuild as part of rpm %check.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports