Skip to content

Draft: coverity: Allow tainted data sinks for talloc functions

Andreas Schneider requested to merge samba-team/devel/samba:asn-coverity into master

I tried again to teach Coverity about talloc() to get rid of false positives. I've found https://github.com/python/cpython/blob/main/Misc/coverity_model.c which implements it the same way. I've already uploaded the modelling file, but the last run didn't fix anything.

See e.g. CID 1464145

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports