Skip to content

simplify samba-tool password redaction

Douglas Bagnall requested to merge samba-team/devel/samba:douglas-simple-setproctitle into master

As per https://bugzilla.samba.org/show_bug.cgi?id=15289 during password redaction for process titles, user input (namely their password) is copied verbatim into a regular expression. This changes it into an arbitrary different, possibly invalid, regular expression.

We now re-use the samba_cmdline_burn() code for consistency.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Andrew Bartlett

Merge request reports