Skip to content

lib/replace - add extra check to bsd_attr_list

Andrew Walker requested to merge samba-team/devel/samba:anodos325-add-bsd-attr-list-check into master

The FreeBSD extattr API may return success and truncated namelist. We need to check for this in bsd_attr_list to ensure that we don't accidentally read off the end of the buffer. In the case of a truncated value, the pascal strings for attr names will reflect the lengths as if the value were not truncated. For example: 58DosStrea

In case of short read we now set error to ERANGE and fail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15271

I'm uncertain about best errno to set here, but ERANGE seemed sensible.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Andrew Walker

Merge request reports