Skip to content

cope with an "old Samba" missing a working GET_ANC

Andrew Bartlett requested to merge samba-team/devel/samba:abartlet/samba-4.4-upgrade into master

This is a feature to assist in Samba upgrades on sites that are running a very old version, where the DRSUAPI_DRS_GET_ANC is not implemented correctly.

We detect WERROR_DS_DRA_MISSING_PARENT and skip doing a critical objects replication, and just jump into the full replication.

TODO:

  • Manual testing against an old release

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15189

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Andrew Bartlett

Merge request reports