Skip to content

Draft: pidl/python: Confirm size of list being assigned into an IDL structure

Andrew Bartlett requested to merge samba-team/devel/samba:abartlet/safer-python-lists into master

We should make it harder to break our C side by assigning a python list of the wrong size.

We should extend this to automatically fill in the length if it is an assignable expression, and ideally refuse otherwise (or check, if we need these to work). Currently it is unclear if best practice is to set the length before or after, and setting it after is why the pipeline fails.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports