Skip to content

samba-tool ntacl should report errors better

Douglas Bagnall requested to merge samba-team/devel/samba:douglas-samba-tooling-ntacl into master

In the (perhaps unlikely) event that expected files are missing, samba-tool ntacl is reporting the problem in a very samba-tool way, so that users end up using strace to work out what is going wrong, as per https://bugzilla.samba.org/show_bug.cgi?id=14937.

With this, samba-tool will say "could not access [the missing file]" (along with a strerror, so you know it's not getting too friendly).

Also, we fix some inconsequential leaks.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports