Skip to content

cmdline_s4: re-initialise logging once loadparm is ready

Douglas Bagnall requested to merge samba-team/devel/samba:douglas-logs-better into master

This fixes a bug in 4.15 and 4.16, where source4 components are trying to log particular logging classes to special files, using the smb.conf log level syntax. It wasn't working, and all messages went into the main log.

I'm working on tests for the whole debug system, but this doesn't need to wait.

https://bugzilla.samba.org/show_bug.cgi?id=15076

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports