Fix developer build with clang 13

Martin Schwenkerequested to merge
samba-team/devel/samba:martins/clang into master

Most of these are instances where clang 13 flags variables that are initialised and updated, but never used.

Configuring like this:

CC="clang" \
CFLAGS="-Wno-error=cast-align" \
./configure \
     --enable-developer \
     --abi-check-disable \
     --enable-selftest \
     --with-cluster-support \
     --without-ad-dc \
     --without-json \
     --without-systemd

Without -Wno-error=cast-align the build fails all over the place...

Many of these are old and have been lived with for years, so I doubt we need to backport them.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports