Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Merge requests 154
    • Merge requests 154
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba TeamThe Samba Team
  • SambaSamba
  • Merge requests
  • !2275

samba-tool domain backup: cope better with dangling symlinks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Douglas Bagnall requested to merge samba-team/devel/samba:douglas-backs-up-symlinks into master Dec 01, 2021
  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 1

samba-tool domain backup currently crashes when it tries to backup a symlink to a non-existent file. With these two patches, we first make it not crash, then make it not try to follow the symlink at all.

The second patch will change the behaviour when Samba directories contain symlinks to real files: they will now not be included (symlinks to directories were never followed).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14918

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited Dec 01, 2021 by Andrew Bartlett
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: douglas-backs-up-symlinks