Skip to content

s3:winbindd: Fix winbindd child logfile name handling

Pavel Filipenský requested to merge samba-team/devel/samba:pfilipen-logfile into master

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14852

Winbindd child should use its own logfile log.wb-<name>. Main/parent winbindd is using log.winbindd. This MR removes 3 calls of is_default_dyn_LOGFILEBASE() to make sure that:

  • 1st removal: child uses log.wb- after the fork
  • 2nd removal: child after HUP signal, does not switch to log.winbindd
  • 3rd removal: child after smbcontrol reload-config, does not switch to log.winbindd

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports