Skip to content

s3:lib: No implicit keytab update for 'net ads changetrustpw'

Pavel Filipenskýrequested to merge
samba-team/devel/samba:pfilipen-changetrustpw_v2 into master

This is a first step for !1999 (closed). Keytab update will no longer happen silently, but only if explicitly specified via a new smb.conf parameter that will be introduced soon in MR 1999.

This fix only removes the implicit keytab update done by net ads changetrustpw if kerberos method is secrets and keytab or system keytab.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports