Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar

GitLab 15.0 has launched! Please visit Breaking changes in 15.0 and 15.0 Removals to see which breaking changes may impact your workflow.

  • The Samba Team
  • SambaSamba
  • Merge requests
  • !2110

smbd "deadtime" parameter doesn't work anymore

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Ralph Böhme requested to merge samba-team/devel/samba:slow-deadtime-bug14783 into master Aug 08, 2021
  • Overview 13
  • Commits 2
  • Pipelines 6
  • Changes 3

It seems the deadtime checking was broken by commit 70fa7e81.

It seems that since 70fa7e81 check_open_pipes() which checks the number of existing policy handles doesn't go back to 0 after smbd's startup code has intialized the RPC services which create policy handles as part of the initialisation. That code in part doesn't close the handles explicitly and instead relies on closing the pipe to free the associated policy handles.

Since 70fa7e81 the s3 code lacks the logic to decerement the numner of open policy handles when an pipe or association group is closed.

https://bugzilla.samba.org/show_bug.cgi?id=14783

Edited Aug 10, 2021 by Ralph Böhme
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: slow-deadtime-bug14783