Skip to content

s3:param:py_param - fix crash when modifying passdb.Groupmap()

Andrew Walker requested to merge samba-team/devel/samba:anodos325-fix-crash-in-py_passdb into master

We try to strlcpy() into NULL on changing the nt_name or comment in a newly-created Groupmap object.

>>> from samba.samba3 import passdb
>>> grp = passdb.Groupmap()
>>> grp.nt_name="canary"
zsh: segmentation fault (core dumped)  python3

Commit changes behavior so that we talloc_strdup() the value.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Andrew Walker

Merge request reports