Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Merge requests 138
    • Merge requests 138
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba Team
  • SambaSamba
  • Merge requests
  • !1753

Fix "winbind:ignore domains"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Ralph Böhme requested to merge samba-team/devel/samba:slow-winbind-ignore-domains into master Jan 12, 2021
  • Overview 7
  • Commits 13
  • Pipelines 11
  • Changes 11

"winbind:ignore domains" stopped working a while ago due to the commits that removed the parameter "map untrusted to domain" in Samba 4.8 cf commits 443984b8 and especially e7bc23e4.

As a side note, even in older version "winbind:ignore domains" was only effective for NTLM authentication. The NTLM auth code uses the trusted domain list as part of the code the implements "map untrusted to domain" and this is the part where auth will fail is a domain is blacklisted.

https://bugzilla.samba.org/show_bug.cgi?id=14602

Edited Jan 20, 2021 by Ralph Böhme
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: slow-winbind-ignore-domains