Skip to content

s3:utils - explicitly free cmdline_messaging_context

Andrew Walker requested to merge samba-team/devel/samba:anodos325-free-cmdline-messaging-contexts into master

Some command line utilities do not free their messaging context which results in extra entries being left in the msg.lock directory.

root@homenas[/mnt/dozer/foo]# ls -lh /var/run/samba4/msg.lock | wc -l
      15
root@homenas[/mnt/dozer/foo]# net conf > /dev/null                   
root@homenas[/mnt/dozer/foo]# ls -lh /var/run/samba4/msg.lock | wc -l
      16

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports