Skip to content

WIP: Extend test for parameter "inherit owner"

Customer wants to use inherit owner = yes in the same way as setgid bit works in unix. The option Inherit Owner in smb.conf enables the group ownership to be set correctly, however this option results in the create directory(and files) being owned by the user that owns the parent directory. But the files/dirs should be owned by the current user, not by the parent dir owner. For group ownerships inherit owner = yes works good. It enables inheritance from parent dir. In source3/script/tests/test_inherit_owner.sh we don't have tests for group ownership. And I think that tests that check owner for subdirs/subfiles are incorrect. They should be checked with $SERVER/$USERNAME instead of $SERVER/force_user.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Denis Karpelevich

Merge request reports