Skip to content

s4:libnet:py_net - free event context in dealloc fn

Andrew Walker requested to merge samba-team/devel/samba:anodos325-fix-leak-in-s4-libnet-py_net into master

Noticed this while testing / using python bindings. Every time a Net() object is created the associated tevent_context isn't freed (even if we del / garbage collect). Simple fix appears to be to free the event context (ev) rather than its talloc_child (mem_ctx) in the deallocation function.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports