Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Merge requests 164
    • Merge requests 164
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba TeamThe Samba Team
  • SambaSamba
  • Merge requests
  • !166

samba-tool drs showrepl: do not crash if no dnsHostName found

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Andrew Bartlett requested to merge samba-team/devel/samba:abartlet-drs-showrepl-v4-9 into v4-9-test Dec 16, 2018
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

This should not happen, but it does sometimes in an autobuild environment. Rather than reporting this by crashing, we report it by showing there is no DNS name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13716

Signed-off-by: Douglas Bagnall douglas.bagnall@catalyst.net.nz Reviewed-by: Andrew Bartlett abartlet@samba.org Autobuild-User(master): Douglas Bagnall dbagnall@samba.org Autobuild-Date(master): Fri Oct 12 15:27:07 CEST 2018 on sn-devel-144

(cherry picked from commit 2fc855e7)

Edited Dec 16, 2018 by Andrew Bartlett
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: abartlet-drs-showrepl-v4-9