Remove extra safe_string.h file

Matthew DeVorerequested to merge
matvore/samba:strhdrs into master

In the interest of simplifying the header files, I removed one of the two headers named safe_string.h. I also removed some transitive inclusions.

The safe_string.h file that I kept prevents all includers of it from using str(n?)casecmp, but there were a lot of source files using those functions which used the old safe_string.h. Not being sure if the restriction on using str(n?)casecmp is something we want to keep, I opted to keep the restriction, but allow existing users to still use it.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite/doc updates (n/a: the code still builds, and this is a straightforward refactor)
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports