Skip to content

s3 rpc server: set on-wire handle type explicitly

Alexander Bokovoy requested to merge samba-team/devel/samba:abbra-create_policy_hnd-use-handle_type-fixup into master

Since wire_handle.handle_type is uint32_t, we can simply assign uint8_t handle type to it without using SIVAL() macros. Further unify with s4 RPC server code flow.

Fixes CID 1462616

CID 1462616: (CONSTANT_EXPRESSION_RESULT) "(uint32_t)handle_type >> 16" is 0 regardless of the values of its operands. This occurs as a value. 284 SIVAL(&rpc_hnd->wire_handle.handle_type, 0 , handle_type);

Signed-off-by: Alexander Bokovoy ab@samba.org

Merge request reports