Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Samba Samba
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Merge requests 161
    • Merge requests 161
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • The Samba TeamThe Samba Team
  • SambaSamba
  • Merge requests
  • !1164

samba-tool group commands do not handle group names with special chars correctly

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Björn Baumbach requested to merge samba-team/devel/samba:bbaumbach-listmembers into master Feb 26, 2020
  • Overview 5
  • Commits 8
  • Pipelines 2
  • Changes 2

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14296

Example:

Creating a group with brackets in its name works:

# samba-tool group add 'samba (R)'
Added group samba (R)

But the delete command does not find the group by its name:

# samba-tool group delete 'samba (R)'
ERROR: Unable to find group "samba (R)"

Other commands like listmembers are also affected.

Use binary encoded group names to fix the affected commands.

Edited Feb 26, 2020 by Björn Baumbach
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bbaumbach-listmembers