Skip to content

Support Faraday 2.x on 1-4-stable branch, for subsequent 1.x release

Peter Bolingrequested to merge
github/fork/jrochkind/1-4-support-faraday-2 into 1-4-stable

Created by: jrochkind

For subsequent 1.x release supporting faraday 2.x -- gemspec is unchanged as to how old a faraday it allows, all the way back to 0.8 as per previous 1.x release.

Backported enough from master to get tests passing on both/either faraday 1.x AND 2.x.

I have confirmed locally that bundle exec rspec passes using both Faraday 1.9.3 and Faraday 2.2.0, by making local uncommitted edits the Gemfile to force both.

CI will of course only run with one version of Faraday. I'm not sure if it will actually be 1.x or 2.x -- see https://github.com/oauth-xx/oauth2/pull/561#issuecomment-1041714757

But this should make it possible to do a 1.4 release that allows and works with Faraday 2.x?

Merge request reports