Skip to content

Remove log level markers from specs matching Faraday log output

Peter Bolingrequested to merge
github/fork/dgholz/dgholz/fix_tests_for_faraday_log_msgs into master

Created by: dgholz

Faraday v1.0.0 changed how requests and responses are logged: previously, the headers and bodies were logged at DEBUG and the other details were logged at INFO. https://github.com/lostisland/faraday/pull/1079 changed the logging to always use the same level for all the details, and defaulted to INFO.

Some oauth2 specs check if the requests & responses are as expected by examining logging from faraday, and include the log level markers in the expected text. Updating the markers to INFO works fine, except for Ruby 2.2: faraday-1.0.0 requires a Ruby version greater than 2.3 and thus on Ruby 2.2 the previous version of faraday is used. oauth2 tests against Ruby 2.2, so it need the expected log output to match on both faraday-0.17.3 and faraday-1.0.0.

This PR addresses https://github.com/oauth-xx/oauth2/pull/489 & https://github.com/oauth-xx/oauth2/pull/492.

Merge request reports