Upgrade rubocop to version 0.56.0

Created by: depfu[bot]

We've upgraded a dependency and all tests pass. \o/

name	version specification	new version
rubocop	~> 0.55.0	0.56.0

You should probably take a good look at this before merging this pull request, of course.

What changed?

✳️ rubocop ( → 0.56.0) · Repo · Changelog

Release Notes

From the Github release:

New features

• #5848: Add new Performance/InefficientHashSearch cop. (@JacobEvelyn)
• #5801: Add new Rails/RefuteMethods cop. (@koic)
• #5805: Add new Rails/AssertNot cop. (@composerinteralia)
• #4136: Allow more robust Layout/ClosingParenthesisIndentation detection including method chaining. (@jfelchner)
• #5699: Add consistent_relative_to_receiver style option to Layout/FirstParameterIndentation. (@jfelchner)
• #5821: Support AR::Migration#up_only for Rails/ReversibleMigration cop. (@koic)
• #5800: Don't show a stracktrace for invalid command-line params. (@shanecav84)
• #5845: Add new Lint/ErbNewArguments cop. (@koic)
• #5871: Add new Lint/SplatKeywordArguments cop. (@koic)
• #4247: Remove hard-coded file patterns and use only Include, Exclude and the new RubyInterpreters parameters for file selection. (@jonas054)

Bug fixes

• Fix bug in Style/EmptyMethod which concatenated the method name and first argument if no method def parentheses are used. (@thomasbrus)
• #5819: Fix Rails/SaveBang when using negated if. (@Edouard-chin)
• #5286: Fix Lint/SafeNavigationChain not detecting chained operators after block. (@Darhazer)
• Fix bug where Lint/SafeNavigationConsistency registers multiple offenses for the same method call. (@rrosenblum)
• #5713: Fix Style/CommentAnnotation reporting only the first of multiple consecutive offending lines. (@svendittmer)
• #5791: Fix exception in Lint/SafeNavigationConsistency when there is code around the condition. (@rrosenblum)
• #5784: Fix a false positive for Rails/HasManyOrHasOneDependent when using nested with_options. (@koic)
• #4666: --stdin always treats input as Ruby source irregardless of filename. (@PointlessOne)
• Fix auto-correction for Style/MethodCallWithArgsParentheses adding extra parentheses if the method argument was already parenthesized. (@dvandersluis)
• #5668: Fix an issue where files with unknown extensions, listed in AllCops/Include were not inspected when passing the file name as an option. (@drenmi)
• #5809: Fix exception Lint/PercentStringArray and Lint/PercentSymbolArray when the inspected file is binary encoded. (@akhramov)
• #5840: Do not register an offense for methods that nil responds to in Lint/SafeNavigationConsistency. (@rrosenblum)
• #5862: Fix an incorrect auto-correct for Lint/LiteralInInterpolation if contains numbers. (@koic)
• #5868: Fix Rails/CreateTableWithTimestamps when using hash options. (@wata727)
• #5708: Fix exception in Lint/UnneededCopEnableDirective for instruction '# rubocop:enable all'. (@balbesina)
• Fix auto-correction of Rails/HttpPositionalArgumnets to use session instead of header. (@rrosenblum)

Changes

• Split Style/MethodMissing into two cops, Style/MethodMissingSuper and Style/MissingRespondToMissing. (@rrosenblum)
• #5757: Add AllowInMultilineConditions option to Style/ParenthesesAroundCondition cop. (@Darhazer)
• #5806: Fix Layout/SpaceInsideReferenceBrackets when assigning a reference bracket to a reference bracket. (@joshuapinter)
• #5082: Allow caching together with --auto-correct. (@jonas054)
• Add try! to the list of whitelisted methods for Lint/SafeNavigationChain and Style/SafeNavigation. (@rrosenblum)
• #5886: Move Style/EmptyLineAfterGuardClause cop to Layout department. (@koic)

Commits

See the full diff on Github. The new version differs by 60 commits:

• Cut 0.56
• Fix `Rails/CreateTableWithTimestamps` when using hash options (#5868)
• [Fix #5708] Handle comment `rubocop:enable all` bug (#5810)
• Fix Style/MethodCallWithArgsParentheses autocorrect adding extra parens (#5825)
• Move `Style/EmptyLineAfterGuardClause` cop to `Layout`
• Add consistent_relative_to_receiver to FirstParameterIndentation (#5699)
• Fix Style/CommandLiteral autocorrection when %x is not configured
• Cleanup HttpPositionalArguments tests
• Fix auto-correction of HttpPositionalArgs to use session instead of header
• Add new `Lint/SplatKeywordArguments` cop (#5871)
• Add spec for JSONLoad autocorrect
• Fix bug in the examples of NodePattern documentation
• Make it easier to find writing custom cops guide
• Add more tests for Lint/DuplicateMethods
• Remove unused method from NestedPercentLiteral
• Remove unneeded `comment_on_line?` check
• [Fix #4247] Make all file inclusion lists configurable
• Clarify GitHub account displayed by `rake new_cop`
• Correct Layout/EmptyLineBetweenDefs docs (#5852)
• Fix documentation for Rails/Present cop
• [Fix #5862] Fix incorrect autocorrect `Lint/LiteralInInterpolation`
• Move some cop options to config/default.yml
• Don't concatenate method name and arguments in empty methods without method def parentheses
• [Fix #5082] Allow --auto-correct to use the cache when possible (#5857)
• Whitelist try! from safe navigation cops
• [Fix #5840] ignore methods that nil responds to in SafeNavigationConsistency
• Add Performance/InefficientHashSearch cop (#5848)
• [Fix #5800] Replace backtrace with --help suggestion for invalid options (#5816)
• Fix documentation typo
• [Fix #5809] Encoding bug in Lint/PercentStringArray
• Add new `Lint/ErbNewArguments` cop
• [Fix #5668] Fix an issue where included files weren't inspected
• Fix issue when reference brackets are assigned by reference brackets.
• Use expect_offense helpers
• Remove duplicate specs
• Reduce line length (rubocop failure)
• Use faster string concatenation
• Memoize Dir.pwd
• Use incremental digester
• Use shorter config string in digest
• [Fix #5819] Handle negated conditions in Rails/SaveBang (#5820)
• [Fix #5821] Support `AR::Migration#up_only` for `Rails/ReversibleMigration`
• CI against JRuby 9.1.17.0
• [Fix #5757] Add option to allow parentheses around multiline conditions
• [Fix #5789][Fix #4666] Fix STDIN filename handling
• Split Style/MethodMissing into Style/MethodMissingSuper and Style/MissingRespondToMissing (#5811)
• Add new `Rails/AssertNot` cop (#5805)
• Style: Make whitespace changes
• Change ClosingParenthesisIndentation error messages to be more precise
• Change ClosingParenthesisIndentation to be relative to parameters
• [Fix #5713] Make `Style/CommentAnnotation` aware of inline comments (#5780)
• Add new `Rails/RefuteMethods` cop
• Fix broken link in Node Pattern doc
• Fix "No newline at end of file" of relnotes
• Update the copyright years in the manual
• [Fix #5784] Fix false positive for `Rails/HasManyOrHasOneDependent`
• [Fix #5791] Fix NoMethodError in SafeNavigationConsistency when there is code around the condition
• Register a single offense per method in SafeNavigationConsistency
• [Fix #5286] `Lint/SafeNavigationChain` not detecting chained operators after block.
• Improve description and examples of Performance/UnneededSort

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.