Skip to content

Do not test maintainers type incorrectly

Nikolai Kondrashov requested to merge spbnick/kpet-db:do_not_test_maintainers_type_incorrectly into main

Remove an incorrect test for maintainer object type, which leads to maintainer property dictionaries being pasted into XML like this:

<param name="CKI_MAINTAINERS" value="{'name': 'Memory Management', 'email': 'mm-qe@redhat.com'}, {'name': 'Jan Stancek', 'email': 'jstancek@redhat.com'}"/>

The test was trying to differentiate the old maintainer representation as a list of strings and the new representation as a list of dictionaries, but was incorrect.

Removing the test and the handling of the old format fixes the issue and the XML now looks like this:

<param name="CKI_MAINTAINERS" value="Memory Management &lt;mm-qe@redhat.com&gt;, Jan Stancek &lt;jstancek@redhat.com&gt;"/>

Merge request reports