Skip to content

Draft: lpfc/qla2xxx: subsystem testing

Michael Hofmann requested to merge mh21_rh/kpet-db:lpfc-subsystem-testing into main

Background

Test audit

The CKI test audit, for each and every one of the CKI tests, aims to

  • identify the stakeholders that care that specific tests run for certain trigger configurations (path/tree/variant/...)
  • document their reasoning

Triggers where this is not possible are removed from CKI testing.

CKI testing

Testing happens for upstream trees, MRs and during Koji/Brew gating. The cost benefit analysis for the various test stages is described in the testing guidelines.

Stakeholders and types of tests

Currently, information about stakeholders and reasoning is only embedded in kpet-db git history and issues. Roughly, test triggers can be divided into two categories:

  • targeted tests: tests that developers would also run on their local machines/labs to validate a change
  • regression tests: tests for that warm fuzzy feeling that nothing got broken inadvertently by some weird edge case

This MR is about validating/identifying targeted tests and the associated stakeholders.

Kernel Developer Tasks

  • All tests that have target_sources set to something like @label/regex are going to run on MRs if the specified files are changed. Please review that these are tests that you consider useful for your development work and exercise the mentioned files in a "comprehensive" manner.
  • All tests that have trigger_sources with a comment like # @label appended are also going to run for MRs touching this subsystem. Again, please review whether these tests are useful for your development work and exercise the mentioned files in a "comprehensive" manner. If that is the case, these trigger_sources can be changed to the @label/foo syntax as well.
  • For all target_sources/trigger_sources where the above is not true, a stakeholder needs to be identified to own the trigger. If that is not possible, the test triggers can be removed. This doesn't have to occur in the scope of this MR.

Notes

  • If possible, simplify the regular expressions. The @label/ limits any matches to files owned by the subsystem based on the information in owners.yaml.
  • Currently, there are still more tests running on @label MRs.
  • Feel free to take a look around the tests available in kpet-db to see whether you want any other available tests to run on MRs for your subsystem.
  • For any questions, you can find CKI members ready to help in Slack #team-kernel-cki

MR Summary

  • all target_sources owned by subsystem moved to @label/.* syntax
  • all trigger_sources annotated by @label to simplify review
  • more steps...

Part of cki-project/infrastructure#258

Edited by Michael Hofmann

Merge request reports