Skip to content

leap_hrtimer: Use slower frequency and cleanup some things

This patch series:

  • Slows the itimer() resolution down to avoid starving debug systems
  • Cleans up some of the code in various ways
  • Fixes a race where the "check_hrtimer_expires_ontime" may not set the CPU affinity of a thread under test performing its actual test as intended

where possible I kept the style consistent to what was there prior.

A few things I'd do if I had a little more time (that I'm hoping gets into the git log) here in no particular order:

  • Add a Makefile
  • "hrtimer" is written as a single thread and let's bash spawn a thread per CPU. "check_hrtimer_expires_ontime" is a multithreaded application that pins a thread per CPU. It makes sense to me to only take one approach (and the easier approach there to me is the bash spawn one)
  • Clean up spacing and style, its different among the various files
  • Clean up minor shellcheck warnings in runtest.sh
  • Make it more clear what the purpose of each program is, as written its not totally clear what exact scenarios are trying to be tested, so making modifications like this is more difficult as the author has to infer if their change is keeping to the purpose of the test
  • Add a .gitignore in the folder for the executables

Link: https://issues.redhat.com/browse/VROOM-20557 Signed-off-by: Andrew Halaney ahalaney@redhat.com

Edited by Andrew Halaney

Merge request reports

Loading