Skip to content

af_key: add __GFP_ZERO flag for compose_sadb_supported in function pfkey_register

Xin Long requested to merge lxin.redhat/centos-stream-9:bz2075183 into main

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2075183 Tested: compile only CVE: CVE-2022-1353

commit 9a564bccb78a76740ea9d75a259942df8143d02c Author: Haimin Zhang tcs_kernel@tencent.com Date: Tue Mar 8 11:20:28 2022 +0800

af_key: add __GFP_ZERO flag for compose_sadb_supported in function pfkey_register

Add __GFP_ZERO flag for compose_sadb_supported in function pfkey_register
to initialize the buffer of supp_skb to fix a kernel-info-leak issue.
1) Function pfkey_register calls compose_sadb_supported to request
a sk_buff. 2) compose_sadb_supported calls alloc_sbk to allocate
a sk_buff, but it doesn't zero it. 3) If auth_len is greater 0, then
compose_sadb_supported treats the memory as a struct sadb_supported and
begins to initialize. But it just initializes the field sadb_supported_len
and field sadb_supported_exttype without field sadb_supported_reserved.

Reported-by: TCS Robot <tcs_robot@tencent.com>
Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

Signed-off-by: Xin Long lxin@redhat.com

Edited by Xin Long

Merge request reports